FbIN/htmly
1
0
Fork 0
mirror of https://github.com/danpros/htmly.git synced 2026-04-18 03:26:20 +05:30
Code Issues Projects Releases Packages Wiki Activity

Refactor "if" condition for "$_FILES" array

Browse source 
remove unnecessary nested if condition to one liner using AND Boolean operator.
This commit is contained in:
Nikkolai Fernandez 2018-11-04 12:00:38 +08:00 • committed by GitHub
commit faa522d827
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

38
upload.php
View file

@ -26,27 +26,25 @@ if (login()) {
mkdir($dir, 0755, true); mkdir($dir, 0755, true);
} }
if (isset($_FILES)) { if (isset($_FILES) && isset($_FILES['file'])) {
if (isset($_FILES['file'])) { $tmp_name = $_FILES['file']['tmp_name'];
$tmp_name = $_FILES['file']['tmp_name']; $name = basename($_FILES['file']['name']);
$name = basename($_FILES['file']['name']); $error = $_FILES['file']['error'];
$error = $_FILES['file']['error']; $path = $dir . $timestamp . '-' . $name;
$path = $dir . $timestamp . '-' . $name;
$check = getimagesize($tmp_name);
$check = getimagesize($tmp_name);
if($check !== false) {
if($check !== false) { if ($error === UPLOAD_ERR_OK) {
if ($error === UPLOAD_ERR_OK) { $extension = pathinfo($name, PATHINFO_EXTENSION);
$extension = pathinfo($name, PATHINFO_EXTENSION); if (!in_array(strtolower($extension), $whitelist)) {
if (!in_array(strtolower($extension), $whitelist)) { $error = 'Invalid file type uploaded.';
$error = 'Invalid file type uploaded.'; } else {
} else { move_uploaded_file($tmp_name, $dir . $timestamp . '-' . $name);
move_uploaded_file($tmp_name, $dir . $timestamp . '-' . $name);
}
} }
} else {
$error = "File is not an image.";
} }
} else {
$error = "File is not an image.";
} }
} }
@ -61,4 +59,4 @@ if (login()) {
} else { } else {
$login = site_url() . 'login'; $login = site_url() . 'login';
header("location: $login"); header("location: $login");
} }